Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Create Plugins: Better check of overriden '__init__' method #5571

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Sep 5, 2023

Changelog Description

Create plugins do not log warning messages about each create plugin because of wrong __init__ method check.

Additional info

Use __init__ check for each base class of create plugin. Issue caused by #5553 .

Testing notes:

  1. Open publisher.
  2. There should not be any logged warnings if create plugin does not override __init__ or expect system settings in apply_settings.

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Sep 5, 2023
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this works for me!

I did still see this logged:

# *** WRN: >>> { CreateYetiCache }: [ WARNING: Source - Create plugin CreateYetiCache. System settings argument will not be passed to '__init__' and 'apply_settings' methods in future versions of OpenPype. Planned version to drop the support is 3.16.6 or 3.17.0. Please contact Ynput core team if you need to keep system settings. ] 

Which shows that that creator has something wrong and indeed - that's not how you should define attribute definitions! Haha. Will make a PR to fix that too. -> PR is here: #5574

@iLLiCiTiT iLLiCiTiT merged commit d851023 into develop Sep 5, 2023
2 checks passed
@ynbot ynbot added this to the next-patch milestone Sep 5, 2023
@iLLiCiTiT iLLiCiTiT deleted the bugfix/fix-warning-messages-about-overriden-init branch September 6, 2023 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants