Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Create Plugins: Better check of overriden '__init__' method #5571

Merged
merged 2 commits into from
Sep 5, 2023
+10 −2
Merged

Create Plugins: Better check of overriden '__init__' method #5571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c3a0f
better check of overriden '__init__' method
iLLiCiTiT Sep 5, 2023
c3847ae
removed '_method_is_overriden' and use explicit class checks
iLLiCiTiT Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions openpype/pipeline/create/creator_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,16 @@ def __init__(
# Backwards compatibility for system settings
self.apply_settings(project_settings, system_settings)

init_overriden = self.__class__.__init__ is not BaseCreator.__init__
if init_overriden or expect_system_settings:
init_use_base = any(
self.__class__.__init__ is cls.__init__
for cls in {
BaseCreator,
Creator,
HiddenCreator,
AutoCreator,
}
)
if not init_use_base or expect_system_settings:
self.log.warning((
"WARNING: Source - Create plugin {}."
" System settings argument will not be passed to"
Expand Down
Loading