Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7242_Implement review representations in OTIO subset resources. #1036

Merged

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Dec 4, 2024

Changelog Description

These changes fixes the bug for Hiero, Flame and Resolve where we realized that the [Clip media] option of Reviewable Source did not work properly.
See ynput/ayon-hiero#38 for more details.

Additional info

This changes needs to be tested alongside ynput/ayon-hiero#38

Testing notes:

  1. Open Hiero and create instance(s) through the Create Publishable Clip
  2. Set the review source media to [Clip media]
    image
  3. Publish and ensure that the resulting review product is created from the original clip media entire range (untrimmed)

AY-7242

@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition labels Dec 4, 2024
@robin-ynput robin-ynput self-assigned this Dec 4, 2024
@jakubjezek001 jakubjezek001 changed the title Implement review representations in OTIO subset resources. AY-7242_Implement review representations in OTIO subset resources. Dec 5, 2024
@ynbot
Copy link
Contributor

ynbot commented Dec 5, 2024

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks!

@jakubjezek001 jakubjezek001 merged commit b7553ae into develop Dec 5, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the enhancement/review_collect_otio_subset_resource branch December 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants