Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make houdini submissions respect pools groups #10

Merged

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Feb 8, 2024

Changelog Description

Make houdini submissions respect pools groups.
This is done by:

  1. Make collect pools works with some Houdini families/product types.
  2. Make Ayon Houdini submitters get group names from Houdini deadline settings.

Additional info

I made three Houdini deadline setting categories. each for a particular case.
image

Testing notes:

  1. Set pools and groups in ayon deadline addon settings
  2. Publish render and cache to deadline.

@MustafaJafar MustafaJafar force-pushed the bugfix/OP-7353-make_houdini_submissions_respect_pools_groups branch from 765e9cc to 80e3246 Compare February 9, 2024 09:26
@MustafaJafar
Copy link
Contributor Author

While I don't know what should I do on deadline server to test this so I printed the job info in ayon log and it seems to have the proper info in the job info.

DEBUG: DeadlineJobInfo(Plugin='Houdini'
 Frames='1001-1001x1'
 Name='robo_BigRobo_cfx_v166.hip - mantra_ropSplit [EXPORT IFD]'
 Comment=''
 Department=None
 BatchName='robo_BigRobo_cfx_v166.hip'
 UserName='Mustafa_Taher'
 MachineName='Major-Kalawy'
 Pool='ayon'
 SecondaryPool='none'
 Group='export_machines'
 Priority=50
 ChunkSize=10
 .
 .
 .

DEBUG: DeadlineJobInfo(Plugin='Mantra'
 Frames='1001-1001x1'
 Name='robo_BigRobo_cfx_v166.hip - mantra_ropSplit [RENDER]'
 Comment=''
 Department=None
 BatchName='robo_BigRobo_cfx_v166.hip'
 UserName='Mustafa_Taher'
 MachineName='Major-Kalawy'
 Pool='ayon'
 SecondaryPool='none'
 Group='render_machines'
 Priority=50
 ChunkSize=1
.
.
.

DEBUG: DeadlineJobInfo(Plugin='Houdini'
 Frames='1001-1001x1'
 Name='robo_BigRobo_cfx_v166.hip - pointcacheBgeoFarmTest [PUBLISH]'
 Comment=''
 Department=None
 BatchName='Robo - robo_BigRobo_cfx_v166.hip'
 UserName='Mustafa_Taher'
 MachineName='Major-Kalawy'
 Pool='ayon'
 SecondaryPool='none'
 Group='cache_machines'
 Priority=50
 ChunkSize=999999
.
.
.

For reference, This validator works with Houdini
image

moonyuet
moonyuet previously approved these changes Feb 21, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the code; it works as expected. it is great to add use_published (its label name is Use Published Scene) in AYON settings, similar to other hosts(as I notice there is use_published =True in the settings).
Just some opinion: it would be great to move get_attribute_defs function to the end of the code for readability.
EDIT: I find some settings not aligning with the ayon settings I will update you later

@moonyuet moonyuet dismissed their stale review February 21, 2024 07:12

I have found some errors

@moonyuet moonyuet self-requested a review February 21, 2024 07:16
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. (My bad as I switch to wrong branch.)
image

"optional": False,
"active": True,
"priority": 50,
"chunk_size":999999,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is set to 999999, default on plugin is 1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I made this implementation of the farm cache, it is set to 999999 avoid users to set the chunk size when they have relative huge frame range (although there is a setting for this chunk size)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change it in plugin too.. set it to use 999999 ?

@antirotor antirotor merged commit 11e89c1 into develop Mar 19, 2024
@antirotor antirotor deleted the bugfix/OP-7353-make_houdini_submissions_respect_pools_groups branch March 19, 2024 11:42
antirotor pushed a commit that referenced this pull request Jul 2, 2024
…render_targets

Houdini: Support different render targets for usdrender product
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants