-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Make houdini submissions respect pools groups #10
Bugfix: Make houdini submissions respect pools groups #10
Conversation
client/ayon_core/modules/deadline/plugins/publish/submit_houdini_cache_deadline.py
Outdated
Show resolved
Hide resolved
765e9cc
to
80e3246
Compare
While I don't know what should I do on deadline server to test this so I printed the job info in ayon log and it seems to have the proper info in the job info.
|
…espect_pools_groups
…espect_pools_groups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the code; it works as expected. it is great to add use_published
(its label name is Use Published Scene) in AYON settings, similar to other hosts(as I notice there is use_published =True
in the settings).
Just some opinion: it would be great to move get_attribute_defs
function to the end of the code for readability.
EDIT: I find some settings not aligning with the ayon settings I will update you later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…espect_pools_groups
client/ayon_core/modules/deadline/plugins/publish/submit_houdini_render_deadline.py
Outdated
Show resolved
Hide resolved
client/ayon_core/modules/deadline/plugins/publish/submit_houdini_render_deadline.py
Outdated
Show resolved
Hide resolved
"optional": False, | ||
"active": True, | ||
"priority": 50, | ||
"chunk_size":999999, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is set to 999999
, default on plugin is 1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I made this implementation of the farm cache, it is set to 999999 avoid users to set the chunk size when they have relative huge frame range (although there is a setting for this chunk size)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change it in plugin too.. set it to use 999999
?
…espect_pools_groups
…render_targets Houdini: Support different render targets for usdrender product
Changelog Description
Make houdini submissions respect pools groups.
This is done by:
Additional info
I made three Houdini deadline setting categories. each for a particular case.
Testing notes: