AY-6731_Allow CSV ingest to create new shots.

[robin-ynput]

Changelog Description

This work goes along CSV ingest file tweaks on ynput/ayon-traypublisher#36.
It allows ayon-traypublisher to leverage Collect Hierarchy and Extract hierarchy to AYON and benefit from shot logic when ingesting CSV. This make it able to create new shots.

Testing notes:

1. This needs to be tested with Allow CSV ingest to create new shots. ayon-traypublisher#36 ingesting CSV files.

[iLLiCiTiT]

We're adding a lot of csv ingest specific logic into core global plugin. There is "csv_ingest_shot" family, why it is not "shot" in traypublisher? Why we don't set attributes during csv ingest, could we handle that in a different way?

[robin-ynput]

We're adding a lot of csv ingest specific logic into core global plugin. There is "csv_ingest_shot" family, why it is not "shot" in traypublisher? Why we don't set attributes during csv ingest, could we handle that in a different way?

That's a very good point. I tried to explain it in the other PR but let me report it here as well.

The "shot" family expects a lot of timeline/resolution data that comes mostly from OTIO and the editorial host but which do not not exist for CSV ingestion. So I thought about those options:

• A- tweak ayon_core to allow CSV to re-use a subset of the "shot" plugins for shot creation
• B- duplicate some "shot" core logic and create new plugins for CSV ingestion in ayon_traypublisher
• C- Somehow compute some OTIO and resolution data from ingested material in CSV. This'd imply a lot of assumptions and workflow decisions to be made (e.g. how to determine shot range/fps/resolution when multiple products are ingested for a shot ?).

Imo options B was making me duplicate a lot of code and C was too way out of the scope of the initial request so I went with A.. But very happy to change this if you guys disagree or think of something better.

[jakubjezek001]

Looking good

[iLLiCiTiT]

100% add comments why are we doing stuff when there is csv publish for future reference (nobody will remember why it is there).

My point is that we might not make it based on csv_ingest_shot but on some more "generic" family (without csv and ingest in it). Or make the logic data based instead of family based. We're skipping attribute because they are not set on instance when in traypublisher? Well maybe we should not set it if are not filled (you don't need family check for that).

And maybe think about why heroTrack is not filled in traypublisher?

[jakubjezek001]

Imo options B was making me duplicate a lot of code and C was too way out of the scope of the initial request so I went with A.. But very happy to change this if you guys disagree or think of something better.

I like A too. Perhaps if it would be possible we could just simply enhance ayon-traypublisher\client\ayon_traypublisher\plugins\publish\collect_shot_instances.py plugin to allow both shot type instances. Since you can identify editorial type of shot instances by "creator_identifier" instance data key, it would make more sense perhaps stau within the scope of shot family but change the way the data are collected in mentioned plugin.

creator_identifier = instance.data["creator_identifier"]
    if creator_identifier == "editorial_shot":
          # do editorial related otio clip evaluation
	else:
		# do csv ingest logic.

[ynbot]

Task linked: AY-6731 CSV publishing nonexistent hierarchy

[iLLiCiTiT]

Noice!

[jakubjezek001]

it seems that all works as it suppose to.

[krishnaavril]

Hey! Can I get the csv template/sample test file, please? for testing