Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CSV ingest to create new shots. #36

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Allow CSV ingest to create new shots. #36

merged 9 commits into from
Nov 20, 2024

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Nov 12, 2024 •
edited
Loading

Changelog Description

resolve #24

New features:

  • Allow CSV ingest to create new shots for non-existent folder paths
  • Provide additional server settings for Folder and Task creation

image

Additional review information

Current implementation has some limitations:

  • Created shot are pretty much blank as we do not have any OTIO/range/resolution info from the CSV file

Testing notes:

This needs to be tested along those changes in ayon_core: ynput/ayon-core#1010

  1. Create a new package and upload it to your AYON server
  2. In CSV settings, enable missing folder creation (ayon+settings://traypublisher/create/IngestCSV/folder_creation_config)
  3. Prepare a CSV file with Folder Path that do not exist yet
  4. Ingest the CSV file through the publisher option in traypublisher
  5. Ensure data is publish as expected and new blank shot(s) have been created

@robin-ynput robin-ynput self-assigned this Nov 12, 2024
@robin-ynput robin-ynput added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Nov 12, 2024
@robin-ynput robin-ynput mentioned this pull request Nov 12, 2024
Merged
@robin-ynput robin-ynput marked this pull request as ready for review November 12, 2024 22:14
@jakubjezek001
Update folder type field in creator_plugins.py
f199802 
Added enum_resolver and description to folder_type field for better clarity and functionality.
jakubjezek001
jakubjezek001 reviewed Nov 19, 2024
View reviewed changes
client/ayon_traypublisher/plugins/create/create_csv_ingest.py Outdated
Comment on lines 439 to 443
else:
for folder_setting in self.folder_creation_config["folder_type_regexes"]:
if re.match(folder_setting["regex"], name):
folder_type = folder_setting["folder_type"]
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason following Path column data is producing following hierarchy with Folder type decorated in <>

  • /shots/mw_110_01_0060
/shots <Shot>
└── mw_110_01_0060 <Shot>

I believe that since I am using default settings with
image The types should be defined as:

/shots <Shot>
└── mw_110_01_0060 <Folder>

jakubjezek001
jakubjezek001 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My tests were successful. I was using CLI and interactive. All was working as expected. The folder type issue is not a blocker but if @robin-ynput will fix it, it would be benefitial.

@robin-ynput
Copy link
Contributor Author

My tests were successful. I was using CLI and interactive. All was working as expected. The folder type issue is not a blocker but if @robin-ynput will fix it, it would be benefitial.

Thanks for the review, I managed to fix the folder type issue but I had to edit the harcoded value in ayon-core to make it a default instead:
https://github.com/ynput/ayon-core/pull/1010/files#diff-e23278ce4a2b0b416005af0e9b9211e7c2e206320d253284272f156987f42e52R46

Can you please confirm this is OK for you ?

@jakubjezek001
Copy link
Member

Thanks for the review, I managed to fix the folder type issue but I had to edit the harcoded value in ayon-core to make it a default instead: ynput/ayon-core#1010 (files)

Can you please confirm this is OK for you ?

Thanks for the suggestion. I agree that it makes sense to keep it there for the context of shot_data. It makes sense to have the default folder type as Shot. Maybe we should use the same approach as the default task type and have a default folder type too.

image

@robin-ynput
Copy link
Contributor Author

Thanks for the review, I managed to fix the folder type issue but I had to edit the harcoded value in ayon-core to make it a default instead: ynput/ayon-core#1010 (files)
Can you please confirm this is OK for you ?

Thanks for the suggestion. I agree that it makes sense to keep it there for the context of shot_data. It makes sense to have the default folder type as Shot. Maybe we should use the same approach as the default task type and have a default folder type too.

image

Yes that's exactly what in there for now:
image

The Shot harcoded change I mentioned was for ayon-core (which is now a default instead of hardcoded).

@robin-ynput robin-ynput merged commit ac80f79 into develop Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet left review comments

@iLLiCiTiT iLLiCiTiT iLLiCiTiT left review comments

@BigRoy BigRoy BigRoy left review comments

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@robin-ynput robin-ynput

Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AY-6731_CSV publishing nonexistent hierarchy
5 participants
@robin-ynput @jakubjezek001 @BigRoy @iLLiCiTiT @moonyuet