Resolve: update to new publisher #157

jakubjezek001 · 2024-03-07T16:21:29Z

Note

Description is work in progress

Changelog Description

Resolve with adapted latest publisher tool.

Additional info

Adaptation of ynput/OpenPype#5709 (thanks @BigRoy for the kick-off!)

TODO:

- @BigRoy reported that there is auto timeline created which should not
- @BigRoy suggested warning message if there is not anything to be used for creation
- @BigRoy suggested to add plugin info text under ?
- Spliting product types into:
- primary: shot - instance with hierarchy, future context data and attributes placeholder
- secondary: plate, audio, review - instance with media
- Hierarchy and context data should be linked from Shot instance for all secondary product types Traypublisher (TP)
- Each secondary product type which will be created from a clip should have own creator class - like in TP
- OTIO should be using native format rather then our implementation - this way we will be ready for Tony's (@tweak-wtf) retiming.

Testing notes:

To be created

…remove menu_style.qss file. Update pipeline with ResolveHost class changes.

- Renamed functions to use "ayon" instead of "pype" for consistency. - Added backward compatibility for old function names. - Updated marker handling in various plugins for Ayon integration.

… class names. Refactor Creator to ResolveCreator and PublishClip to PublishableClip for consistency. Remove unused imports and code related to LegacyCreator.

…utes and methods for clip creation. Improve GUI settings for shot hierarchy and renaming.

…project. Introduce plugin for collecting current project data and creating otio timeline. Refactor file extraction process for better representation handling.

- Updated function names for consistency and clarity - Renamed menu launcher functions to reflect the current context - Removed unnecessary variables and commented-out code in lib.py

…ndling. Adjust naming conventions for Ayon compatibility.

…ve plugins. Adjust imports accordingly.

BigRoy · 2024-03-07T23:23:26Z

Nice!

Just opening the Publisher creates an empty timeline (easiest to test in empty project) - it should not do anything.
When Clicking Create for Create Publishable Clip but there's no valid clips in timeline nothing happens - and there's no warning or printed message in console. Might be good to provide a Creation Error if it ends up doing nothing. Easily reproducable in empty timeline or timeline without any Chocolate color clips if that toggle is enabled.
Still seems to suffer from the fact that it tries to set an invalid folder path. Which I assume is similar to where the original PR left things unfinished.
Deleting the instances gives me this error:
Might be nice to add a "detailed description" for this creator - for the question mark top right in publisher.

…isher

client/ayon_core/hosts/resolve/api/lib.py

BigRoy · 2024-03-12T09:29:04Z

client/ayon_core/hosts/resolve/api/pipeline.py

@@ -260,3 +263,138 @@ def on_pyblish_instance_toggled(instance, old_value, new_value):
    # Whether instances should be passthrough based on new value
    timeline_item = instance.data["item"]
    set_publish_attribute(timeline_item, new_value)
+
+
+class HostContext:


Could you add a docstring about what this does and what it tries to solve?

It seems overly complex, trying to manage 'data' that should really be INSIDE the project. Why do we need this global cache that also gets removed afterwards. What is this 'context'? Why does it contain 'instances' if it's not workfile related?

I am not sure where should be this comment on. It seems the code had changed a lot.

It seems to be on the right spot still. Basically, what is the HostContext class and why do we need it? Would be good to have a docstring to describe its usage. Why couldn't we store this data within the project?

…isher

ynbot · 2024-06-12T11:56:52Z

Task linked: OP-8066 Resolve: update to new publisher

- Removed the function for loading stylesheets in the menu. - Refactored plugin creation logic to use new API methods and data structures.

…isher

server_addon/resolve/client/ayon_resolve/RESOLVE_API_v19.0B-build20.txt

…ed content related to previous versions.

- Refactored function names and descriptions for clarity - Added new function to export timeline otio files - Improved temporary directory handling for otio files

Adjusted get_otio_temp_dir to set timeline if not provided, throwing error if none found.

…isher

server_addon/resolve/client/ayon_resolve/api/lib.py

Co-authored-by: Roy Nieterau <[email protected]>

…isher

iLLiCiTiT · 2024-07-02T13:21:06Z

PR moved to ayon-resolve repository ynput/ayon-resolve#3

jakubjezek001 added 10 commits March 7, 2024 12:17

Updating Resolve API reference

f7e514a

Add Ayon core constants and menu changes, update AyonMenu class, and …

f943fe7

…remove menu_style.qss file. Update pipeline with ResolveHost class changes.

Update Resolve API functions and markers for Ayon compatibility.

09d7dc6

- Renamed functions to use "ayon" instead of "pype" for consistency. - Added backward compatibility for old function names. - Updated marker handling in various plugins for Ayon integration.

Update plugin classes and imports for backward compatibility with new…

fbd0fc5

… class names. Refactor Creator to ResolveCreator and PublishClip to PublishableClip for consistency. Remove unused imports and code related to LegacyCreator.

Add import statement, update class inheritance, and define new attrib…

b692cde

…utes and methods for clip creation. Improve GUI settings for shot hierarchy and renaming.

Add workfile auto-creator plugin with instance creation logic.

f634f19

Update timeline frame rate settings and add otio metadata to Resolve …

666c76a

…project. Introduce plugin for collecting current project data and creating otio timeline. Refactor file extraction process for better representation handling.

Refactor timeline item retrieval functions and menu launchers

6c42394

- Updated function names for consistency and clarity - Renamed menu launcher functions to reflect the current context - Removed unnecessary variables and commented-out code in lib.py

Update Resolve API functions, containerization methods, and marker ha…

18ccc00

…ndling. Adjust naming conventions for Ayon compatibility.

Remove deprecated functions and use constants for clip color in Resol…

cabf6be

…ve plugins. Adjust imports accordingly.

ynbot added size/XL host: Resolve type: feature Adding something new and exciting to the product labels Mar 7, 2024

jakubjezek001 requested review from BigRoy and iLLiCiTiT March 7, 2024 16:22

jakubjezek001 added 6 commits March 8, 2024 10:59

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

bb5a23d

…isher

fixing bits after renaming and moving into constants

5517438

adding function for getting native otio file

0c84f6f

adding HostContext class for dealing with context in creators

2a64d72

adding abstracted plugins for dealing with new publisher

0d90f57

create otio timeline can optionally add own timeline

d03c2bf

BigRoy reviewed Mar 12, 2024

View reviewed changes

client/ayon_core/hosts/resolve/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 12, 2024

View reviewed changes

client/ayon_core/hosts/resolve/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 12, 2024

View reviewed changes

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

17cfa43

…isher

jakubjezek001 requested a review from BigRoy June 12, 2024 12:38

jakubjezek001 added 2 commits June 12, 2024 15:12

Refactor menu stylesheet loading, update plugin creation logic

6e1851f

- Removed the function for loading stylesheets in the menu. - Refactored plugin creation logic to use new API methods and data structures.

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

553602e

…isher

BigRoy reviewed Jun 12, 2024

View reviewed changes

server_addon/resolve/client/ayon_resolve/RESOLVE_API_v19.0B-build20.txt Outdated Show resolved Hide resolved

jakubjezek001 added 5 commits June 13, 2024 12:15

Update API documentation and keyframe mode information. Remove outdat…

cdc55ed

…ed content related to previous versions.

Refactor otio file handling functions, add temp dir logic.

e1dea1c

- Refactored function names and descriptions for clarity - Added new function to export timeline otio files - Improved temporary directory handling for otio files

Refactor get_otio_temp_dir to handle missing timeline.

e4a11ef

Adjusted get_otio_temp_dir to set timeline if not provided, throwing error if none found.

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

932dfd6

…isher

reverting latest commit changes partly

3d1f0d7

BigRoy reviewed Jun 13, 2024

View reviewed changes

server_addon/resolve/client/ayon_resolve/api/lib.py Outdated Show resolved Hide resolved

jakubjezek001 and others added 4 commits June 14, 2024 12:33

Update server_addon/resolve/client/ayon_resolve/api/lib.py

d105d13

Co-authored-by: Roy Nieterau <[email protected]>

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

4ea3887

…isher

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

cd003ba

…isher

Merge branch 'develop' into feature/AY-979_Resolve-update-to-new-publ…

210d23d

…isher

iLLiCiTiT mentioned this pull request Jul 2, 2024

Resolve: update to new publisher ynput/ayon-resolve#3

Closed

7 tasks

iLLiCiTiT closed this Jul 2, 2024

robin-ynput mentioned this pull request Aug 28, 2024

AY-979 Finalize updating Resolve to new publisher ynput/ayon-resolve#15

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve: update to new publisher #157

Resolve: update to new publisher #157

jakubjezek001 commented Mar 7, 2024 •

edited

Loading

BigRoy commented Mar 7, 2024

BigRoy Mar 12, 2024

jakubjezek001 Jun 13, 2024

BigRoy Jun 13, 2024 •

edited

Loading

ynbot commented Jun 12, 2024

iLLiCiTiT commented Jul 2, 2024

Resolve: update to new publisher #157

Resolve: update to new publisher #157

Conversation

jakubjezek001 commented Mar 7, 2024 • edited Loading

Changelog Description

Additional info

TODO:

Testing notes:

BigRoy commented Mar 7, 2024

BigRoy Mar 12, 2024

Choose a reason for hiding this comment

jakubjezek001 Jun 13, 2024

Choose a reason for hiding this comment

BigRoy Jun 13, 2024 • edited Loading

Choose a reason for hiding this comment

ynbot commented Jun 12, 2024

iLLiCiTiT commented Jul 2, 2024

jakubjezek001 commented Mar 7, 2024 •

edited

Loading

BigRoy Jun 13, 2024 •

edited

Loading