Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve: update to new publisher #157
Resolve: update to new publisher #157
Changes from 5 commits
f7e514a
f943fe7
09d7dc6
fbd0fc5
b692cde
f634f19
666c76a
6c42394
18ccc00
cabf6be
bb5a23d
5517438
0c84f6f
2a64d72
0d90f57
d03c2bf
17cfa43
6e1851f
553602e
cdc55ed
e1dea1c
e4a11ef
932dfd6
3d1f0d7
d105d13
4ea3887
cd003ba
210d23d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a docstring about what this does and what it tries to solve?
It seems overly complex, trying to manage 'data' that should really be INSIDE the project. Why do we need this global cache that also gets removed afterwards. What is this 'context'? Why does it contain 'instances' if it's not workfile related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure where should be this comment on. It seems the code had changed a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be on the right spot still. Basically, what is the
HostContext
class and why do we need it? Would be good to have a docstring to describe its usage. Why couldn't we store this data within the project?