Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing logic for CollectFrameDataFromAssetEntity #52

Closed
wants to merge 1 commit into from
Closed

Implement missing logic for CollectFrameDataFromAssetEntity #52

wants to merge 1 commit into from

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

resolve #50

  • CollectFrameDataFromAssetEntity

Testing notes:

  1. everything should work as before.
  2. Please report if the missing logic should be implemented instead of removing the redundant settings.
  3. Please report if the PR is not backward compatible (copy settings should work fine without implementing conversions)

@MustafaJafar MustafaJafar self-assigned this Dec 10, 2024
@MustafaJafar MustafaJafar added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Dec 10, 2024
@MustafaJafar MustafaJafar mentioned this pull request Dec 10, 2024
Merged
@iLLiCiTiT
Copy link
Member

Resolved with #51 (please don't create doubled PRs if only one should be merged next time).

@iLLiCiTiT iLLiCiTiT closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

@kalisp kalisp Awaiting requested review from kalisp

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@robin-ynput robin-ynput Awaiting requested review from robin-ynput

Assignees

@MustafaJafar MustafaJafar

Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundant settings or implement missing logic
2 participants
@MustafaJafar @iLLiCiTiT