Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant settings from CollectFrameDataFromAssetEntity #51

Merged
merged 4 commits into from
Dec 10, 2024
Merged

remove redundant settings from CollectFrameDataFromAssetEntity #51

merged 4 commits into from
Dec 10, 2024

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Dec 9, 2024 •
edited
Loading

Changelog Description

resolve #50
This PR removes CollectFrameDataFromAssetEntity settings completely. this plugin was previously Optional, but that got later removed ynput/OpenPype@e90d227

Testing notes:

  1. everything should work as before.
  2. Please report if the missing logic should be implemented instead of removing the redundant settings.
  3. Please report if the PR is not backward compatible (copy settings should work fine without implementing conversions)

@MustafaJafar MustafaJafar self-assigned this Dec 9, 2024
@MustafaJafar MustafaJafar added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Dec 9, 2024
@MustafaJafar MustafaJafar requested a review from BigRoy December 10, 2024 09:02
@iLLiCiTiT
Copy link
Member

Shouldn't we fix it so the plugin shows the option in UI, instead of removing the settings?

@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Dec 10, 2024 •
edited
Loading

Shouldn't we fix it so the plugin shows the option in UI, instead of removing the settings?

IDK, I created this alternative PR #52 feel free to merge either one.
@jakubjezek001 @kalisp @robin-ynput any idea about the intended behavior of this plugin CollectFrameDataFromAssetEntit?

@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition and removed type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) labels Dec 10, 2024
@iLLiCiTiT iLLiCiTiT merged commit 7c98adf into develop Dec 10, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the 50-remove-redundant-settings-or-implement-missing-logic branch December 10, 2024 10:32
@iLLiCiTiT iLLiCiTiT mentioned this pull request Dec 10, 2024
Closed
@MustafaJafar MustafaJafar mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@BigRoy BigRoy Awaiting requested review from BigRoy

Assignees

@MustafaJafar MustafaJafar

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundant settings or implement missing logic
3 participants
@MustafaJafar @iLLiCiTiT @BigRoy