Moves Sync dialog outside of Unreal

[kalisp]

New hook is created to show blocking dialog to sync specific change list before Unreal will launched.

It is expected that Perforce workspace is created/set and first version of Unreal project is synced (as discussed previously).

(Version-control logic was removed from ayon-core hook, Sync To button was removed from Unreal Ayon menu.)

Requires:

• Unreal: support in Deadline ayon-deadline#1
• Deadline support ayon-unreal#8

[antirotor]

It cannot be easily tested without solving this:

ayon-version-control/client/version_control/changes_viewer/control.py

Lines 93 to 97 in 91e07fa

	def get_current_project_name(self):
	return "ayon_test" # TEMP!!!
	if self._current_project is None:
	self._current_project = self.get_current_context()["project_name"]
	return self._current_project

[antirotor]

I think we should move it outside the pre-launch hook - to subprocess at least. Having it in pre-launch hook is troublesome because maybe in the future, we will need to run unreal headlessly for example.

[kalisp]

It cannot be easily tested without solving this:

ayon-version-control/client/version_control/changes_viewer/control.py

Lines 93 to 97 in 91e07fa

	def get_current_project_name(self):
	return "ayon_test" # TEMP!!!
	if self._current_project is None:
	self._current_project = self.get_current_context()["project_name"]
	return self._current_project

Fixed.

[kalisp]

I think we should move it outside the pre-launch hook - to subprocess at least. Having it in pre-launch hook is troublesome because maybe in the future, we will need to run unreal headlessly for example.

This feature should be blocking, syncing needs to be done before Unreal editor start. Syncing on Deadline is being handled elsewhere.

Fixed

[antirotor]

not sure if this shouldl be addressed in this PR, but dumping it here anyway:

when you clikc "sync to" button, there is no visual feedback whatsoever - only log in the console if you have it opened. It has the feeling that it doesn't work where it in fact works. Should it (after successful sync) continue to Unreal?

[antirotor]

Just one typo and comment about product name, can be dismissed if not relevant. Otherwise it works.

[antirotor]

Also - something was lost in the repository transfer. This states that it needs ynput/ayon-core#183 that was closed and replaced by ynput/ayon-core#670 that was closed yet again in favour of ynput/ayon-deadline#1 but I think something in 'ayon_core.modules.webserver` was changed, because it doesn't work with the latest develop version of ynput/ayon-core

Pretty hefty traceback at the start of ayon-launcher

WARNING:TrayAddonsManager:Addon "version_control" crashed on `tray_start`.
Traceback (most recent call last):
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-core\client\ayon_core\tools\tray\addons_manager.py", line 202, in start_addons
    addon.tray_start()
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-version-control\client\version_control\addon.py", line 108, in tray_start
    from version_control.rest.communication_server import WebServer
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-launcher\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-version-control\client\version_control\rest\communication_server.py", line 10, in 
    from version_control.rest.perforce.rest_api import PerforceModuleRestAPI
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-launcher\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-version-control\client\version_control\rest\perforce\rest_api.py", line 4, in 
    from version_control.backends.perforce import rest_routes
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-launcher\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-version-control\client\version_control\backends\perforce\__init__.py", line 38, in __getattr__
    return importlib.import_module(f"{__package__}.{name}")
  File "C:\Users\annat\.pyenv\pyenv-win\versions\3.9.13\lib\importlib\__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-version-control\client\version_control\backends\perforce\rest_routes.py", line 7, in 
    from ayon_core.modules.webserver.base_routes import RestApiEndpoint
  File "C:\Users\annat\Documents\Projects\Ayon\ayon-launcher\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
ModuleNotFoundError: No module named 'ayon_core.modules.webserver.base_routes'

[kalisp]

Also - something was lost in the repository transfer. This states that it needs ynput/ayon-core#183 that was closed and replaced by ynput/ayon-core#670 that was closed yet again in favour of ynput/ayon-deadline#1 but I think something in 'ayon_core.modules.webserver` was changed, because it doesn't work with the latest develop version of ynput/ayon-core

Pretty hefty traceback at the start of ayon-launcher

Updated imports.

Fixed.

[antirotor]

works, thanks!