Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Support default setting overrides on different languages (#1368)" #1530

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Revert "Support default setting overrides on different languages (#1368)" #1530

merged 1 commit into from
Oct 26, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Oct 26, 2024 •
edited
Loading

This reverts commit 72a3477 (#1368) to fix playwright tests.

@MarvNC MarvNC requested a review from a team as a code owner October 26, 2024 10:36
jamesmaa
jamesmaa approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unsure if this is tied to playwright being broken but if it's urgent and you're sure it's this PR feel free to merge

@MarvNC MarvNC added this pull request to the merge queue Oct 26, 2024
Merged via the queue into yomidevs:master with commit 019c458 Oct 26, 2024
12 checks passed
@MarvNC MarvNC deleted the fix-playwright branch October 26, 2024 18:06
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 27, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
2e46f5d 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
@jamesmaa jamesmaa mentioned this pull request Oct 27, 2024
Merged
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 27, 2024
@jamesmaa
Revert "Reapply "Support default setting overrides on different langu…
856fefe 
…ages (yomidevs#1368)" (yomidevs#1530)"

This reverts commit 2e46f5d.
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 28, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
2a61c69 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 28, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
dd70fae 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 29, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
a4a683a 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
github-merge-queue bot pushed a commit that referenced this pull request Nov 1, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (#1… (
7c198d4 
#1535)

* Reapply "Support default setting overrides on different languages (#1368)" (#1530)

This reverts commit 019c458.

* Make recommended settings lazy-load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvNC @jamesmaa