feat: <Picker> 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyunsDev
requested review from
yoo-jimin127,
nijuy and
Hanna922
as code owners
nijuy
approved these changes
Oct 19, 2023
Hanna922
requested changes
Oct 20, 2023
| import { PickerProps } from './Picker.type'; | ||
| import { StyledPicker } from './Picker.style'; | ||
|
|
||
| export const Picker = forwardRef<HTMLDivElement, PickerProps>(({ children, ...props }, ref) => { |
There was a problem hiding this comment.
Picker 한 개당 최대 3개의 PickerColumn을 가질 수 있다는 제한 사항이 있어서 갯수 제한을 설정해주시면 더 좋을 것 같아요!
There was a problem hiding this comment.
이 부분은 디자인적으로만 고려해도 충분할 것 같고, 추후 확장 가능성을 위해 의도적으로 추가하지 않았어요.
갯수 제한을 걸려면 context로 컴포넌트의 수를 센 다음에 3개 초과면 오류를 던저야 하는데, 이 정도의 오버헤드를 감수하면서 개발 단에서 제한을 추가할 필요는 없을 것 같습니다.
nijuy
approved these changes
Nov 21, 2023
Hanna922
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치지 않는 변경사항
useDOMRef훅 추가useUncontrolledValue()훅 추가<Picker>컴포넌트 추가2️⃣ 알아두시면 좋아요!
<Picker>컴포넌트의 구현이 조금 복잡하게 되어 있어요. 주석의 개선이나 코드를 조금 더 깔끔하게 할 수 있는 방법이 있다면 알려주세요!3️⃣ 추후 작업
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?