fix: <Toggle> displayName, export문 추가 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* components/index.ts 에 Toggle 관련 export 문을 추가했습니다.
Hanna922
reviewed
Oct 20, 2023
| @@ -39,3 +39,4 @@ export const Toggle = forwardRef<HTMLDivElement, ToggleProps>( | |||
| ); | |||
| } | |||
| ); | |||
| Toggle.displayName = 'Toggle'; | |||
There was a problem hiding this comment.
노션 보면 forwardRef나 점으로 연결된 컴포넌트가 추가 대상으로 되어있어서 뱃지에는 안 붙여도 될 거 같은데 다른 컴포넌트 (버튼들)은 필요할 거 같아요!!
Hanna922
approved these changes
Oct 20, 2023
|
원래 작업이 끝나면 브랜치도 삭제해야 하지만!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치지 않는 변경사항
displayName추가기존 코드에 영향을 미치는 변경사항
component/index.ts에 Toggle 관련 export문 추가➡ 만약 Picker보다 이 PR이 먼저 머지된다면!! 이 부분 때문에 feat/picker에서 develop 한번 더 받아와야 할 거 같아요
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?