chore: clean and speed up fhe training tests #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBredehoft
commented
Jun 11, 2024
| @@ -470,6 +470,6 @@ def deserialize_decrypt_dequantize( | |||
|
|
|||
| # In training mode, note that this step does not make much sense for now. Still, nothing | |||
| # breaks since QuantizedModule don't do anything in post-processing | |||
| result = self.model.post_processing(*result) | |||
| result_post_processed = self.model.post_processing(*result) | |||
RomanBredehoft
force-pushed
the
chore/clean_speed_up_fhe_training_tests
branch
from
3b9384f to
d31429a
Compare
jfrery
previously approved these changes
Jun 13, 2024
RomanBredehoft
force-pushed
the
chore/clean_speed_up_fhe_training_tests
branch
from
d31429a to
d1d0988
Compare
jfrery
approved these changes
Jun 13, 2024
Coverage passed ✅Coverage details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are compiling the fhe training circuit for fhe execution but only do simulation, which should speed up the test by a x2 factor. Usually compilation is quick, but in the composition case it can take around tens of seconds so this can save several minutes of running
for that, I need to remove the fixed values we've put in our compile method, which are not breaking changes since these are Concrete's default values + should allow anyone to be able to only compile for simulation or fhe execution (as explained abvoe)