Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 ArtifactStore auth issue #3086

Merged
merged 9 commits into from
Oct 17, 2024
Merged

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 15, 2024

Describe changes

Fixes the authentication issued introduced with #3060

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 15, 2024
@avishniakov avishniakov added the bug Something isn't working label Oct 15, 2024
@avishniakov
Copy link
Contributor Author

@stefannica I made the requested changes and tested this in different conditions: with new perms present or without for the legacy connector - all seems good. Shall we merge it? CI is a bit shaky, but I can merge it like this - there are only docker failures not related to the PR.

@avishniakov avishniakov merged commit f57ca18 into develop Oct 17, 2024
53 of 55 checks passed
@avishniakov avishniakov deleted the bugifx/fix-s3-as-auth-issue branch October 17, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants