Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 ArtifactStore auth issue #3086

Merged
merged 9 commits into from
Oct 17, 2024
Merged

Fix S3 ArtifactStore auth issue #3086

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b14e6dd
use credentials from connector or secret
avishniakov Oct 15, 2024
eea0acf
reusable fix
avishniakov Oct 16, 2024
036ae13
Refactor S3ArtifactStore's _boto3_bucket method return type
avishniakov Oct 16, 2024
2286b8d
Merge branch 'develop' into bugifx/fix-s3-as-auth-issue
avishniakov Oct 16, 2024
fcca81d
yet another fix
avishniakov Oct 17, 2024
d2428e4
add safety belt for backwards compatibility
avishniakov Oct 17, 2024
843ee53
Refactor S3ArtifactStore's _boto3_bucket method return type
avishniakov Oct 17, 2024
a46a347
avoid double underscores
avishniakov Oct 17, 2024
382fe59
Refactor S3ArtifactStore's versioning handling
avishniakov Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/zenml/integrations/s3/artifact_stores/s3_artifact_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,14 @@ def __init__(
super().__init__(*args, **kwargs)

# determine bucket versioning status
s3 = boto3.resource("s3")
key, secret, token, region = self.get_credentials()
s3 = boto3.resource(
"s3",
aws_access_key_id=key,
aws_secret_access_key=secret,
aws_session_token=token,
region_name=region,
)
bucket = s3.Bucket(self.config.bucket)
versioning = bucket.Versioning()
if versioning.status == "Enabled":
Expand Down
Loading