modules: hal_silabs: Add Proprietary TRX example #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-pouiller
requested changes
Dec 22, 2023
fkokosinski
requested changes
Jan 8, 2024
This exemple only work with Silabs specific API. I don't think it makes sense to place it in Zephyr repo, do you? However, I believe it makes sense to publish it somewhere. Do you think it should be published on an external repository? Note Espressif already publish examples with their HAL: |
Hi! You're right indeed, and we should be fine with hosting these samples here in the SiLabs HAL then :) Thanks for pointing that out. |
fkokosinski
reviewed
Jan 8, 2024
examples/proprietary_trx/src/config/rail/brd2601b/radio_settings.radioconf
Outdated
Show resolved
Hide resolved
examples/proprietary_trx/src/config/rail/brd2602a/radio_settings.radioconf
Outdated
Show resolved
Hide resolved
zohavas
force-pushed
the
add_example_radio_trx
branch
2 times, most recently
from
f9876a9
to
527d38d
Compare
jerome-pouiller
requested changes
Jan 19, 2024
examples/proprietary_trx/src/main.c
Outdated
| } | ||
| if (s_obj.events & EVENT_RADIO_ERROR) { | ||
| smf_set_state(SMF_CTX(&s_obj), &radio_states[ERROR]); | ||
| } |
There was a problem hiding this comment.
I believe if two events raise in the same iteration, one of them will be ignored. The occurrence of the bug will depends of the execution time of the functions declared in radio_states.
BTW, if we miss the EVENT_RADIO_SENT event, we won't be able to send anything anymore.
zohavas
force-pushed
the
add_example_radio_trx
branch
3 times, most recently
from
5541cd5
to
576b290
Compare
zohavas
force-pushed
the
add_example_radio_trx
branch
3 times, most recently
from
7463b7b
to
ee150d9
Compare
jerome-pouiller
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Hello @zohavas.
Usually I tried to give all my comments in the two first version of a PR. Unfortunately, some of my comments are still related to code existing since the first version. I am sorry about that, I know it is not convenient.
zohavas
force-pushed
the
add_example_radio_trx
branch
2 times, most recently
from
5cec2c7
to
34580b1
Compare
jerome-pouiller
requested changes
Jan 29, 2024
zohavas
force-pushed
the
add_example_radio_trx
branch
from
34580b1
to
cfced72
Compare
zohavas
force-pushed
the
add_example_radio_trx
branch
2 times, most recently
from
a0b3eaa
to
ac3b80a
Compare
jerome-pouiller
approved these changes
Feb 1, 2024
|
@fkokosinski we are almost ready, we need to validate some things with our legal department. Please wait with the merge until we are ready, thank you. |
Add Proprietary TRX example to show SiliconLabs radio board capabilities. Signed-off-by: Zoltan Havas <[email protected]>
zohavas
force-pushed
the
add_example_radio_trx
branch
from
ac3b80a
to
ebc2b4d
Compare
|
@fkokosinski thank you for waiting, we are ready with the requested legal validation, the merge can go, thank you for your help! |
Thanks for the ping. Please note that Zephyr is currently in a feature freeze, meaning we shouldn't be merging anything until it ends on February 23rd. I would also prefer to have 2 ACKs on the PR to Zephyr before moving with this to be sure that these changes will be pulled into Zephyr. |
nordicjm
requested changes
Aug 29, 2024
jhedberg
requested changes
Aug 29, 2024
|
|
||
| .. code-block:: bash | ||
|
|
||
| west build -p always -b efr32bg22_brd4184a |
There was a problem hiding this comment.
This should IMO include two prior steps:
west update hal_silabs
west blobs fetch hal_silabs
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Sep 19, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
[1]: zephyrproject-rtos/hal_silabs#49
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Sep 19, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
[1]: zephyrproject-rtos/hal_silabs#49
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Sep 19, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
[1]: zephyrproject-rtos/hal_silabs#49
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Oct 10, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
[1]: zephyrproject-rtos/hal_silabs#49
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Oct 10, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
[1]: zephyrproject-rtos/hal_silabs#49
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
Also note that files generated by Simplicity Studio (rail_config.*) ends
lines with \r. To pass Zephyr compliance, this patch imports these files
with \r removed:
sed -i 's/\r//g' */rail_config.[hc]
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Oct 14, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
[1]: zephyrproject-rtos/hal_silabs#49
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
Also note that files generated by Simplicity Studio (rail_config.*) ends
lines with \r. To pass Zephyr compliance, this patch imports these files
with \r removed:
sed -i 's/\r//g' */rail_config.[hc]
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Oct 14, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
[1]: zephyrproject-rtos/hal_silabs#49
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
Also note that files generated by Simplicity Studio (rail_config.*) ends
lines with \r. To pass Zephyr compliance, this patch imports these files
with \r removed:
sed -i 's/\r//g' */rail_config.[hc]
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to jerome-pouiller/zephyr-silabs
that referenced
this pull request
Oct 14, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
[1]: zephyrproject-rtos/hal_silabs#49
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
Also note that files generated by Simplicity Studio (rail_config.*) ends
lines with \r. To pass Zephyr compliance, this patch imports these files
with \r removed:
sed -i 's/\r//g' */rail_config.[hc]
Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
added a commit
to SiliconLabsSoftware/zephyr-silabs
that referenced
this pull request
Oct 14, 2024
This introduce an example of use of Rail library in Zephyr.
This is a reboot of PR[1]. Compared to the original PR, this version:
- remove some files imported from Simplicity Studio. Only
radio_config.[ch] are kept.
- drop the useless Finite State Machine
[1]: zephyrproject-rtos/hal_silabs#49
For now only two boards (based xg22 and xg24) are supported. I hope to
add support for all the Series-2 boards in the future.
Note Zephyr does not allow to host samples application in HALs. Samples
specific to one board and using non-standard APIs are not very welcomed
in the main repo. So, the Silabs downstream is probably the best (the
only) place to provide publish it.
Also note that files generated by Simplicity Studio (rail_config.*) ends
lines with \r. To pass Zephyr compliance, this patch imports these files
with \r removed:
sed -i 's/\r//g' */rail_config.[hc]
Signed-off-by: Jérôme Pouiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Proprietary TRX example to show SiliconLabs radio board capabilities.