cmake: toolchain: Remove deprecated 'xtools' toolchain variant #80466
Conversation
stephanosio
force-pushed
the
goodbye_xtools
branch
3 times, most recently
from
d929a40
to
eeba816
Compare
|
The documentation compliance check failure should be ignored since we do not want to be modifying the previous release notes: |
Given these are genuine rst "bugs" causing broken links etc. I think it wouldn't be the end of the world to fix them, now that you're editing the file. But generally speaking, I totally agree with you about not touching past release notes, and that's why I intentionally didn't touch them when introducing the linter |
|
It feels like it would be nice to get this in for 4.0 since carrying over deprecated stuff for too long is never a good thing, but maybe it's too late for this time around. If this is to make it, I guess we'd want to also mention it in the release notes? |
|
@stephanosio Kindly help fix merge conflict |
stephanosio
dismissed stale reviews from tejlmand, nandojve, and kartben
via
711c08b
stephanosio
force-pushed
the
goodbye_xtools
branch
from
eeba816
to
711c08b
Compare
|
Rebased |
|
Thanks @stephanosio! Can you confirm you also addressed the boards recently added as part of your latest rebase? |
Yes |
|
welp, conflict again ... |
The `xtools` toolchain variant, which was originally introduced to be used with the Crosstool-NG-based Zephyr SDK toolchains and has been replaced by the `zephyr` toolchain variant, has been marked as deprecated since Zephyr v3.3.0. Signed-off-by: Stephanos Ioannidis <[email protected]>
The `xtools` toolchain variant has been deprecated since Zephyr v3.3.0 and now removed. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes all references to the `xtools` toolchain variant in the
board YAML files.
Note that the `xtools` toolchain variant has been deprecated since Zephyr
v3.3.0 and now removed.
The removal process was automated using the following command line:
git grep -l xtools -- boards/*.{yml,yaml} | \
xargs -n 1 -P $(nproc) \
yq -i 'del(.toolchain[] | select(. == "xtools"))'
Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes all references to the `xtools` toolchain variant in the twister scripts. Note that the `xtools` toolchain variant has been deprecated since Zephyr v3.3.0 and now removed. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit removes the TF-M support for the `xtools` toolchain variant, which has been deprecated since Zephyr v3.3.0 and now removed. Note that `zephyr` toolchain variant must be used instead of `xtools` when building with Zephyr SDK. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
force-pushed
the
goodbye_xtools
branch
from
711c08b
to
422f4d7
Compare
|
Rebased again. Hopefully this is the last time ... |
|
@stephanosio given this needs superpowers and will never show in the merge dashboard (and if you want to merge as-is--I would personally be fine with actually fixing the linting errors in the rst files, as they are legit "bugs"), I recommend you keep an eye on approvals and merge this yourself as soon as ready |
This series removes the
xtoolstoolchain variant, which has been deprecated in #51334 and since Zephyr v3.3.0, and all the references to it throughout the Zephyr codebase.Note that the
xtoolstoolchain variant (aka. Crosstool-NG) was originally introduced to be used with the Crosstool-NG-based Zephyr SDK toolchains.This is no longer necessary because the current Zephyr SDK already has its own
zephyrtoolchain variant, which fully replaces thextoolstoolchain variant, and thextoolstoolchain variant serves no purpose at all.Note that, for generic GNU toolchain, the
cross-compiletoolchain variant must be used andxtoolstoolchain variant was never intended for that purpose.