General fix for MSPI drivers and Apollo3p mspi feature update #81762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 impostor SHA Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_ambiq
DNM
swift-tk
force-pushed
the
apollo3p-mspi-feature-update
branch
from
970a5e9 to
b0e390a
Compare
swift-tk
changed the title
swift-tk
commented
Nov 22, 2024
zephyrbot
added
platform: Ambiq
de-nordic
reviewed
Nov 22, 2024
swift-tk
force-pushed
the
apollo3p-mspi-feature-update
branch
3 times, most recently
from
5435c3c to
6ca2b9d
Compare
de-nordic
reviewed
Nov 22, 2024
de-nordic
reviewed
Nov 22, 2024
de-nordic
reviewed
Nov 22, 2024
swift-tk
force-pushed
the
apollo3p-mspi-feature-update
branch
from
6ca2b9d to
505d24f
Compare
Standarlized transfer priority and add a medium level. Signed-off-by: Swift Tian <[email protected]>
swift-tk
force-pushed
the
apollo3p-mspi-feature-update
branch
5 times, most recently
from
2c6a15e to
4051429
Compare
The example now takes necessary information from the device tree and print better transfer status. The packets are re-ordered to show more complex transfer scenario. Signed-off-by: Swift Tian <[email protected]>
swift-tk
force-pushed
the
apollo3p-mspi-feature-update
branch
from
4051429 to
3621190
Compare
|
Further improve the mspi_async example.
|
1. Moved ambiq specific macro to mspi_ambiq header. 2. Always fill rx&tx dummy settings regardless of transfer direction. 3. Add the CONFIG_MSPI_* macro for optional features. 4. Fixed the ID read process and add k_sleep during busy_wait in atxp032 driver. Signed-off-by: Swift Tian <[email protected]>
1. Use the newly introduced am_hal_mspi_cq_scatter_xfer api 2. Remove async PIO support 3. Use separate AM_HAL_MSPI_REQ_SCRAMB_CONFIG instead of am_hal_mspi_device_configure 4. Add MSPI_DEVICE_CONFIG_RX_DUMMY & MSPI_DEVICE_CONFIG_TX_DUMMY support and bug fix. 5. Unblock sync dma transcieve. 6. The transfers now able to be queued from different async mspi_transceive calls. Signed-off-by: Swift Tian <[email protected]>
Add the flash_mspi_atxp032 driver to the example and verified that flash_mspi_atxp032_read_sfdp is working as expected. Signed-off-by: Swift Tian <[email protected]>
swift-tk
force-pushed
the
apollo3p-mspi-feature-update
branch
from
3621190 to
c6e81b9
Compare
|
Please create a PR of HAL to update the correct SHA. Overall it looks good to me. |
RichardSWheatley
approved these changes
Dec 11, 2024
fabiobaltieri
added
DNM (manifest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for the common files
Ambiq specific update:
Introduce the
am_hal_mspi_cq_scatter_xferapi with three modes(STREAM, NORMAL, LOOP) that can dynamically set transfer related settings in command queue.Tests:
\zephyr\tests\drivers\mspi\api
\zephyr\tests\drivers\mspi\flash
\zephyr\samples\drivers\jesd216
\zephyr\samples\drivers\memc
\zephyr\samples\drivers\mspi\mspi_async
\zephyr\samples\drivers\mspi\mspi_flash