Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(posts-saga/matrix-client): update post saga to support media uploads, create optimistic posts, handle media mapping in events, and add test coverage for full functionality #2241

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Sep 4, 2024

What does this do?

  • This PR enhances the post functionality by enabling media uploads, creating optimistic posts, and ensuring proper media handling in events.

Why are we making this change?

  • We are making this change to improve user experience by supporting media attachments in posts and providing immediate visual feedback through optimistic updates.

How do I test this?

  • run tests as usual
  • NOTE :: this is not yet wired up to the UI

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

…oads, create optimistic posts, handle media mapping in events, and add test coverage for full functionality
@domw30 domw30 requested a review from a team September 4, 2024 13:45
Base automatically changed from feat/add-post-input-component to main September 5, 2024 10:48
…ds-create-optimistic-posts-handle-media-mapping-in-events-and-update-send-post-tests-for-full-functionality
@domw30 domw30 merged commit 9d3d8b5 into main Sep 5, 2024
5 checks passed
@domw30 domw30 deleted the feat/update-post-saga-to-support-media-uploads-create-optimistic-posts-handle-media-mapping-in-events-and-update-send-post-tests-for-full-functionality branch September 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant