Added 'make ansible_lint' and fixed some of the ansible-lint issues reported #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-hub-warnings
branch
3 times, most recently
from
343affe to
c81daa9
Compare
andy-maier
force-pushed
the
andy/fix-hub-warnings
branch
2 times, most recently
from
12ceed7 to
9c388a2
Compare
andy-maier
added a commit
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Andreas Maier <[email protected]>
andy-maier
added a commit
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-hub-warnings
branch
2 times, most recently
from
9d0a3f6 to
5cd31ca
Compare
andy-maier
added a commit
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-hub-warnings
branch
from
5cd31ca to
8b10d7d
Compare
andy-maier
changed the title
andy-maier
force-pushed
the
andy/fix-hub-warnings
branch
from
8b10d7d to
2c450b9
Compare
andy-maier
changed the title
|
Even though the |
|
@anilak11 Since I don't know how to get rid of these warnings, ansible-lint's non-0 exit code is intentionally ignored for now (by using the minus in front of its command line in the Makefile). |
…eported Details: * Added ansible-lint to the development dependencies. Needed to increase some package dependencies for development and also for installation. * Added a new make target 'ansible_lint' for running ansible-lint, in order to get a preview of the AutomationHub import warnings. * Added 'make ansible_lint' as a new step to the Github Actions test workflow. * Resolved the issues reported by 'make ansible_lint' where possible. The remaining issues are those that are also reported by the Ansible AutomationHub import. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-hub-warnings
branch
from
2c450b9 to
f25a3d5
Compare
anilak11
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
This PR originally was motivated by issue #784, but it was only possible to resolve some additional ansible-lint issues, not the original ones reported during AutomationHub import.