Fixed warning about ignoring label 'adapter/port' #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
added
dont merge
under work
review needed
and removed
dont merge
under work
labels
Details: * Fixed warning about ignoring label 'adapter/port' on metric group 'partition-attached-network-interface' due to error in rendering the Jinja2 expression for a label value. (issue #450) Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-label-ignore-warning-adapter-port
branch
from
46d0cd2 to
7114ff0
Compare
simon-spinner
approved these changes
Feb 23, 2024
anilak11
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Tested the change on the HMC of A224. However, I could not reproduce the new log message when adding NICs.
Also, in tests on dal12z1.CPCB where the problem originally was observed on partition dal2-qz2-sr2-rk070-m09 it could not be reproduced. We ran the old exporter and an exporter with the code from this PR in parallel for 2 days, but creating NICs did not trigger the situation.
Even though we don't understand yet what triggers the situation, the change in this PR handles the situation definitely better than before, soI think we should go ahead with the PR.