This repository has been archived by the owner on Jun 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #70 (I think)
If the content-length header is empty,
size
gets set tofalse
, which is sent in as thehighWaterMark
option tothrough2
, which is passed toreadable-stream
, which eventually raises an error saying "false is not a valid value" or something similar, but only on version 3.x, which is whatnpm
uses (even though this project doesn't).I did write a test for this, but could never get it to trigger because it's caused by some sort of dependency mismatch that happens in npm but not in this repo, so I removed the test. Even when I installed [email protected], it didn't trigger, because
through2
is the only dependency that requiresreadable-stream
, which is not the case innpm
. When I updated justthrough2
'sreadable-stream
version, I got a different error entirely, so I'm not sure if this weird dependency thing is the only issue, but I do know we're not supposed to passhighWaterMark: false
, so this should still be a valid fix.