Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing attachments from primary in secondary #2

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tipue-dev
Copy link

The article attachments are not carried over to the secondary if an internal note is created in the primary.
This also means, that the article itself in the secondary is plain text instead of HTML.

image

@rkaldung rkaldung added the Feature New feature or request label Oct 12, 2023
@rkaldung
Copy link
Member

I labeled this PR as a feature because the behavior is new to the add-on. I checked it with a 6.0.x

Question: Should a system configuration setting added to keep the "original" behavior? I think some systems not to want to have attachments replicated to all secondary tickets.

@rkaldung rkaldung added the Clarification Clarification is needed. label Oct 12, 2023
@rkaldung rkaldung requested review from rkaldung and removed request for NiklasSchmitt October 12, 2023 18:05
@tipue-dev
Copy link
Author

@rkaldung I think that in every other case, attachments are copied over. A system configuration that only excludes attachments for internal notes looks strange, if seen on its own.

For existing users, I don't imagine that agents expect attachments for other articles to be transferred but not internal notes (from prior experience, yes, but not because this is expected behaviour). I also assume those articles will probably have less attachments in general, so I don't see an argument for memory usage here also.

If you think memory usage might be a concern for some users, then I would propose a general solution that allows it to load attachments from other tickets. All Secondary articles could load all attachments from the associated Primary article. Ticket split could use the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clarification Clarification is needed. Feature New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants