Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcached cache module for Znuny #417

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

pboguslawski
Copy link
Contributor

Proposed change

This mod allows one to implement enterprise, multiserver Znuny installations with shared cache moved from slow NFS-like solutions to faster Memcached server.

Requires Cache::Memcached::Fast installed (libcache-memcached-fast-perl package in Debian).

Cache benchmarking possible with otrs.Console.pl Dev::Tools::CacheBenchmark.

Note: memcached service (i.e. memcached -m 256 -I 16m from official image) must be listening at address configured with Cache::Module::Memcached###Servers for cache unit tests to pass. This CI adjustment is not a part of this PR.

Type of change

  • '1 - 🚀 feature' - New feature (which adds functionality to an existing integration)

Additional information

Author-Change-Id: IB#1046574

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

Author-Change-Id: IB#1046574
Fixes: 6bca153
Author-Change-Id: IB#1046574
Fixed comment style to satisfy code policy.

Fixes: f4eae1ddf4bc7d047d66a560584995ed1c6e5672
Author-Change-Id: IB#1046574
Worker processes must use own connections to memcached to avoid
races.

Fixes: f4eae1ddf4bc7d047d66a560584995ed1c6e5672
Author-Change-Id: IB#1046574
Fixes: d4abf57a6d6e21fdb05c4c6fd30498bca0f4f7df
Author-Change-Id: IB#1046574
Fixes: f4eae1ddf4bc7d047d66a560584995ed1c6e5672
Author-Change-Id: IB#1046574
Fixes: fa94f4d78ac87d420d155bbce11363f23723a8b8
Author-Change-Id: IB#1234567
Fixes: f4eae1ddf4bc7d047d66a560584995ed1c6e5672
Author-Change-Id: IB#1046574
Author-Change-Id: IB#1046574
Author-Change-Id: IB#1046574
Author-Change-Id: IB#1046574
@dennykorsukewitz dennykorsukewitz added the 1 - 🚀 feature New feature or request label Jun 9, 2023
@joserribeiro26
Copy link
Contributor

@rkaldung @dennykorsukewitz
Is this feature on the roadmap for the next versions?
It's very interesting for scalability, we use it here when we set up a good environment with multiple front-ends.

@rkaldung
Copy link
Member

rkaldung commented Nov 5, 2023

@rkaldung @dennykorsukewitz Is this feature on the roadmap for the next versions? It's very interesting for scalability, we use it here when we set up a good environment with multiple front-ends.

@joserribeiro26 Either this PR here or #112 would be great. But both PRs have any unit tests and this is no-go.

@pboguslawski
Copy link
Contributor Author

But both PRs have any unit tests and this is no-go.

Redis is not Memcached and Memcached is not Redis so both PR's should be considered as separate features. Standard unit test checks all availabe cache backends so no need for separate unit tests for this PR.

@rkaldung
Copy link
Member

rkaldung commented Nov 5, 2023

But both PRs have any unit tests and this is no-go.

Redis is not Memcached and Memcached is not Redis so both PR's should be considered as separate features. Standard unit test checks all availabe cache backends so no need for separate unit tests for this PR.

👍 Who said they are identical? If all backends are covered by the default unit test that's fine, never checked this. @dennykorsukewitz Can you confirm that existing unit tests cover also this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🚀 feature New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants