Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: Fixed uninitialized value in AdminSelectBox #611

Merged

Conversation

jsinagowitz
Copy link
Contributor

Proposed change

Each time the SQL statement in the AdminSelectBox does not return any results, the following error message is displayed in the Apache error log:

index.pl: Use of uninitialized value $MatchesFound in numeric ge (>=) at /opt/znuny/bin/cgi-bin/../../Kernel/Modules/AdminSelectBox.pm line 158.
index.pl: Use of uninitialized value $MatchesFound in numeric gt (>) at /opt/znuny/bin/cgi-bin/../../Kernel/Modules/AdminSelectBox.pm line 163.
  • '1 - 🐞 bug 🐞'

Additional information

Steps to reproduce:

  • Go to Admin -> SQL Box
  • Insert the SQL-statement: SELECT * FROM article WHERE false
  • Go to console and open the error log: e.g. /var/log/httpd/error_log
  • Find the uninitialized value error messages

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsinagowitz ,
thanks for your PR.

Approved 👍

Regards 🚀

@dennykorsukewitz dennykorsukewitz added 1 - 🐞 bug 🐞 An issue with the system. 3 - wait for merge Znuny, it's your turn. labels Oct 25, 2024
@dennykorsukewitz dennykorsukewitz self-assigned this Oct 25, 2024
@dennykorsukewitz dennykorsukewitz added this to the rel-7_1_4 milestone Oct 25, 2024
@dennykorsukewitz
Copy link
Member

dennykorsukewitz commented Oct 25, 2024

@dennykorsukewitz dennykorsukewitz added the 4 - verified This issue or pull request was verified. label Oct 25, 2024
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for merge Znuny, it's your turn. label Nov 1, 2024
@dennykorsukewitz dennykorsukewitz merged commit 860fb7c into znuny:dev Nov 1, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

2 participants