Engines #120
Merged
Engines #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertyg
approved these changes
Sep 9, 2024
| ) | ||
|
|
||
| @cached | ||
| @retry(wait=wait_random_exponential(min=1, max=5), stop=stop_after_attempt(3)) |
There was a problem hiding this comment.
do we want to make retries optional too?
There was a problem hiding this comment.
let's land this first and then try to fix this
| api_key=os.getenv("OPENAI_API_KEY") | ||
| ) | ||
|
|
||
| def validate(self) -> None: |
There was a problem hiding this comment.
perhaps we can check content here too. e.g., if no user message, may be good to throw an exception
There was a problem hiding this comment.
it's a good idea but currently this is used in init, we can add that in a future update, I want first to have ppl test thsi
This was referenced Sep 28, 2024
Merged
vinid
force-pushed
the
fede/sadfactoring-engines
branch
from
d698782 to
4999f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.