Fix ArduPilot starting alt locations #23674
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
May 3, 2023
magicrub
reviewed
May 3, 2023
| @@ -555,6 +555,9 @@ float Aircraft::rangefinder_range() const | |||
| // Add some noise on reading | |||
| altitude += sitl->sonar_noise * rand_float(); | |||
|
|
|||
| // this rangefinder is mounted on the simulated frame, 5cm off the ground: | |||
| altitude += 0.05; | |||
There was a problem hiding this comment.
Does this jive with RNGFND1_GNDCLEAR?
peterbarker
force-pushed
the
pr/fix-rangefinderdriver-test
branch
from
d490b4e to
726d300
Compare
rmackay9
requested changes
Aug 9, 2023
peterbarker
force-pushed
the
pr/fix-rangefinderdriver-test
branch
from
726d300 to
132aac0
Compare
Fixed. |
|
is this worth a 4.4.1 backport? |
SITL was starting with a negative height-above-ground, which is very confusing
SITL was starting with a negative height-above-ground, which is very confusing
peterbarker
force-pushed
the
pr/fix-rangefinderdriver-test
branch
from
132aac0 to
e5d3095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... simulation was starting off underground; this was causing an integer wrap in our simulated rangefinders, which was unpleasant.