Rover: implement external control #25204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2023
srmainwaring
force-pushed
the
prs/pr-rover-external-control
branch
from
508ba01 to
83715a6
Compare
Ryanf55
reviewed
Oct 18, 2023
| Return true if Copter is ready to handle external control data. | ||
| Currently checks mode and arm states. | ||
| */ | ||
| bool ready_for_external_control(); |
There was a problem hiding this comment.
Could add WARN_IF_UNUSED for these two functions
There was a problem hiding this comment.
Could do. They're not marked as such in the Copter implementation of external control. What's the recommended house style for adding these attributes?
There was a problem hiding this comment.
I'd add them to Copter, perhaps in a separate PR. It's just additional compile-time-safety, not critical or a blocker.
There was a problem hiding this comment.
Ok - maybe we could do as a follow up in both cases to keep things consistent.
Ryanf55
approved these changes
Oct 23, 2023
Signed-off-by: Rhys Mainwaring <[email protected]> Rover: update comment in Rover/AP_ExternalControl_Rover.h Co-authored-by: Nick E <[email protected]>
srmainwaring
force-pushed
the
prs/pr-rover-external-control
branch
from
267457d to
2c609c6
Compare
IamPete1
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement external control for Rover.
Testing
Tested in Gazebo with WildThumper robot, cartographer and navigation 2.