Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Scripting: fixed rudder in sport aerobatics #25309

Merged
merged 2 commits into from
Oct 23, 2023
Merged

AP_Scripting: fixed rudder in sport aerobatics #25309

merged 2 commits into from
Oct 23, 2023

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Oct 19, 2023

rudder was not being activated in sport aerobatics

@tridge tridge requested a review from Hwurzburg October 19, 2023 01:10
Hwurzburg
Hwurzburg reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works unless you stop the mission using it, restart the mission later, then knife edge fails again untill scripting is restarted

actually cant find a pattern...seems a bit random...how my suggested change seems to make it solid...

@tridge
Copy link
Contributor Author

tridge commented Oct 20, 2023

actually cant find a pattern...seems a bit random...how my suggested change seems to make it solid...

what suggested change?

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Oct 20, 2023 •
edited
Loading

??? its right above your question...move your added line to line 259 in the pitch_controller instead of line 331....that makes it reliable for some reason

@tridge tridge force-pushed the pr-sport-aerobatics-rudder branch from f6fb604 to 18d964a Compare October 22, 2023 21:17
@Hwurzburg
Copy link
Collaborator

SITL tested...looks good now..

@tridge tridge merged commit 13d5668 into ArduPilot:master Oct 23, 2023
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg approved these changes

Assignees
No one assigned
Labels
Scripting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tridge @Hwurzburg @CraigElder