-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Logger: correct the filling order of the struct #25362
AP_Logger: correct the filling order of the struct #25362
Conversation
Which compiler? |
@peterbarker |
We've moved forward in our assumed compiler standards, I'm afraid. Please upgrade your compiler; Also note that Ubuntu 18.04 is out of LTS, so more problems may arise into the future... we stopped fixing Python2 problems as soon as it went out of support, for example! |
@peterbarker |
this is correctly supported by recent compiler so we don't need this patch that is a bit less performant than the direct initilization. thanks anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xianglunkai turns out we actually do use g++ 7.5.0 - on our build server for non-ChibiOS targets.
I'm planning on merging this once CI passes - because at the moment we're not getting "latest" builds for many of our linux-based boards (e.g. https://firmware.ardupilot.org/Plane/latest/bbbmini/)
Thanks!
Merged, thanks @xianglunkai . |
correct compilation errors like this:
../../libraries/AP_Logger/AP_Logger_Backend.cpp: In member function ‘bool AP_Logger_Backend::Write_VER()’:
../../libraries/AP_Logger/AP_Logger_Backend.cpp:577:5: sorry, unimplemented: non-trivial designated initializers not supported
};
^