Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Logger: correct the filling order of the struct #25362

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

xianglunkai
Copy link
Contributor

correct compilation errors like this:
../../libraries/AP_Logger/AP_Logger_Backend.cpp: In member function ‘bool AP_Logger_Backend::Write_VER()’:
../../libraries/AP_Logger/AP_Logger_Backend.cpp:577:5: sorry, unimplemented: non-trivial designated initializers not supported
};
^

@xianglunkai xianglunkai changed the title correct the filling order of the struct, otherwise it may cause compi… AP_Logger: correct the filling order of the struct Oct 25, 2023
@peterbarker
Copy link
Contributor

Which compiler?

@xianglunkai
Copy link
Contributor Author

@peterbarker
ubuntu18.04 arm-gcc7.5

@peterbarker
Copy link
Contributor

@peterbarker ubuntu18.04 arm-gcc7.5

We've moved forward in our assumed compiler standards, I'm afraid.

Please upgrade your compiler; apt is easy enough for the Linux compiler, and we provide the release stm32 compiler on firmware.ardupilot.org if needed.

Also note that Ubuntu 18.04 is out of LTS, so more problems may arise into the future... we stopped fixing Python2 problems as soon as it went out of support, for example!

@xianglunkai
Copy link
Contributor Author

@peterbarker
Txs!
But I think it's best to fix this small issue to prevent testing by other users

@khancyr
Copy link
Contributor

khancyr commented Nov 1, 2023

this is correctly supported by recent compiler so we don't need this patch that is a bit less performant than the direct initilization. thanks anyway

@khancyr khancyr closed this Nov 1, 2023
@peterbarker peterbarker reopened this Nov 9, 2023
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xianglunkai turns out we actually do use g++ 7.5.0 - on our build server for non-ChibiOS targets.

I'm planning on merging this once CI passes - because at the moment we're not getting "latest" builds for many of our linux-based boards (e.g. https://firmware.ardupilot.org/Plane/latest/bbbmini/)

Thanks!

@peterbarker peterbarker merged commit 4f00dfa into ArduPilot:master Nov 10, 2023
172 of 173 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks @xianglunkai .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants