-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Rally: support altitude frames #25380
Conversation
This is strongly desired from a urgent need to get support for absolute or relative rally points supported. A later change that let us have full missions in rally points would be quite interesting, but we'd like to get this in now, and this should be no impact for existing ground stations as we never had assigned a value to those flag bits in the XML. (Out of spec of course is a different story). |
261fbb3
to
5c87169
Compare
If the rally point alt frame is set to terrain does a copter actually follow the terrain to the rally point or does it fly a straight line to the absolute altitude (which matches the specified alt-above-terrain)? |
@rmackay9 Your correct, on copter it flys to the abs altitude and then flys the return based on the I was going to chalk that up as a future improvement, but I could add it to this PR if you prefer. |
@IamPete1, Ah, OK. Let's not let perfection be the enemy of the good.. |
…YPE takes precedence
0c83d47
to
7a84598
Compare
This work is sponsored by Spektreworks.
This adds support for alt frames in rally points. There were some free bits in "flags" that we can use. This assumes that those unused bits are zero. It is possible that they are none zero in storage if uploaded with the old
RALLY_POINT
MAVLink message.Tested conversion from old format, all alt frames manually on plane and added new method to the existing
TerrainRally
plane test.