Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Switch to DCM to get Better GPS if DCM Isn't Using GPS #25707

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Don't Switch to DCM to get Better GPS if DCM Isn't Using GPS #25707

merged 1 commit into from
Jan 1, 2024

Conversation

njwhite
Copy link
Contributor

@njwhite njwhite commented Dec 5, 2023

Look at the parameter to see if DCM uses GPS; if not don't prefer DCM for using GPS.

@njwhite njwhite force-pushed the patch-1 branch 4 times, most recently from 16146cb to 47f916f Compare December 10, 2023 14:57
@tridge
Copy link
Contributor

tridge commented Dec 11, 2023

@njwhite I've rebased this, and fixed the commit comment for our style guidelines. Good change, thanks!
please also see the recent addition of AHRS_OPTIONS that gives you control over the DCM fallback
#25676

@njwhite
Copy link
Contributor Author

njwhite commented Dec 17, 2023

@tridge CI has passed - could you merge please? Thanks -

IamPete1
IamPete1 previously requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to drop the merge commit

@njwhite njwhite requested a review from IamPete1 December 30, 2023 23:38
@njwhite @IamPete1
AP_AHRS: Don't Switch to DCM to get Better GPS if DCM Isn't Using GPS
c471b9d 
Look at the parameter to see if DCM uses GPS; if not don't prefer DCM for using GPS.
@IamPete1 IamPete1 dismissed their stale review December 31, 2023 21:33

Commit msg fixedup and merge commit removed.

@tridge tridge merged commit 03ae947 into ArduPilot:master Jan 1, 2024
88 checks passed
@njwhite
Copy link
Contributor Author

njwhite commented Jan 1, 2024

@tridge @IamPete1 thanks for you help getting this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

@IamPete1 IamPete1 Awaiting requested review from IamPete1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njwhite @tridge @IamPete1