Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted header changes fror AP_Custom #26150

Merged
merged 8 commits into from
Feb 10, 2024

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Feb 6, 2024

In preparation for AP_Custom (or whatever we call it...)

Randy pointed out we should have a noun, and we had these suggestions:

AP_CustomVehicle?
AP_GenericVehicle?

I think I like AP_CustomVehicle as someone pointed out it wouldn't be a bad target for the custom build server...

Board               AP_Periph  antennatracker  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       *               *      *           *       *                 *      *      *
HerePro             0                                                                                     
Hitec-Airspeed      *                                                                                     
KakuteH7-bdshot                *               *      *           *       *                 *      *      *
MatekF405                      *               *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot             *               *                  *       *                 *      *      *
f103-QiotekPeriph   *                                                                                     
f303-Universal      *                                                                                     
iomcu                                                                           *                         
revo-mini                      *               *      *           *       *                 *      *      *
skyviper-v2450                                                    *                                       

@peterbarker peterbarker changed the title Pr/ap custom bits Extracted header changes fror AP_Custom Feb 6, 2024
@rmackay9
Copy link
Contributor

rmackay9 commented Feb 7, 2024

I'd vote for "Vehicle", "GenericVehicle", "EmptyVehicle" or "NullVehicle". I'm not a huge fan of "CustomVehicle" because nearly all AP vehicles are customised.

My favourite is just "Vehicle".

@tridge
Copy link
Contributor

tridge commented Feb 7, 2024

good to merge with minor #else change

@tridge tridge removed the DevCallEU label Feb 7, 2024
@peterbarker peterbarker merged commit 0e67209 into ArduPilot:master Feb 10, 2024
92 checks passed
@peterbarker peterbarker deleted the pr/ap_custom_bits branch February 12, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants