Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: use standard FPV config for SpeedyBeeF405WING #26327

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

andyp1per
Copy link
Collaborator

We get endless support questions relating to features of the SpeedyBeeF405WING - e.g. https://discuss.ardupilot.org/t/speedybee-f405-wing-no-esc-telemetry/112650 - this PR simply adopts minimize_fpv_osd which includes all the features that people are after. There is still 50k flash free after this.

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this although we should inform SpeedyBee before merging since they actually specified what features to remove...I can tell them
Also why did choosing to add the ESC telem in the build server NOT work to enable this? are we going to fix that?

@andyp1per
Copy link
Collaborator Author

@Hwurzburg as far as I know this does not remove any additional features - it only adds in missing features

@Hwurzburg
Copy link
Collaborator

@Hwurzburg as far as I know this does not remove any additional features - it only adds in missing features
it does...the bolded ones I consider issues:
!AP_ADVANCEDFAILSAFE_ENABLED
-!HAL_BARO_WIND_COMP_ENABLED
-!AP_CAMERA_MAVLINK_ENABLED
-!AP_CAMERA_MOUNT_ENABLED
-!HAL_DISPLAY_ENABLED
-!HAL_HIGH_LATENCY2_ENABLED
-!AP_INERTIALSENSOR_KILL_IMU_ENABLED
-!AP_LANDINGGEAR_ENABLED
-!AP_LTM_TELEM_ENABLED
-!AP_MAVLINK_MSG_MOUNT_CONFIGURE_ENABLED
-!AP_MAVLINK_MSG_MOUNT_CONTROL_ENABLED
-!AP_MAVLINK_MSG_RELAY_STATUS_ENABLED
-!AP_MISSION_NAV_PAYLOAD_PLACE_ENABLED
-!AP_MOTORS_FRAME_DECA_ENABLED
-!AP_MOTORS_FRAME_DODECAHEXA_ENABLED
-!AP_MOTORS_FRAME_OCTAQUAD_ENABLED
-!AP_MOTORS_FRAME_Y6_ENABLED
-!HAL_MOUNT_ALEXMOS_ENABLED
-!HAL_MOUNT_ENABLED
-!HAL_MOUNT_SERVO_ENABLED

-!HAL_MOUNT_SIYI_ENABLED
-!HAL_MOUNT_STORM32SERIAL_ENABLED
-!AP_NOTIFY_NCP5623_ENABLED
-!AP_RC_CHANNEL_AUX_FUNCTION_STRINGS_ENABLED
-!AP_SBUSOUTPUT_ENABLED
-!QAUTOTUNE_ENABLED

@andyp1per
Copy link
Collaborator Author

@Hwurzburg ok I have added those back in - still 15k free which seems decent

@tridge tridge merged commit b359ec8 into ArduPilot:master Feb 28, 2024
41 checks passed
@andyp1per andyp1per deleted the pr-spd405-wing branch February 28, 2024 10:44
@andyp1per andyp1per mentioned this pull request Mar 13, 2024
@rmackay9 rmackay9 mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4.5.0-beta3
Development

Successfully merging this pull request may close these issues.

3 participants