Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest: improve diagnostics around log download #26371

Conversation

peterbarker
Copy link
Contributor

I did consider factoring this, but thought laying out the mavproxy commands in one place was better, still. I reserve the option to change my mind there....

@peterbarker
Copy link
Contributor Author

  • MAVProxy's retry logic needs help
    • 20 retries/0.7 seconds isn't appropriate, should be a bandwidth limit for requests-sent
    • current logic will retry the same blocks all the time (until they're satisfied
      • should be creating a queue of requests when the queue is empty, then empty the queue
      • until full size is reached that queue would just have the chunk missing from the end
  • ArduPilot should ignore attempts to change the span being downloaded while it is sending a span
  • the current autotests involving MAVProxy are fundamentally flawed when using an unreliable transport such as UDPMulticast.
    • MAVProxy has no retry for "log list". If replies are lost (and they are!), then MAVProxy never emits the key string which the autotest suit is looking for ("logNum" etc)
  • there appears to be a bug in mavproxy_log.py
    • if a log is an exact multiple of 90 bytes long then we will not fill gaps
    • line 65, m.count==0
  • we still have problems with draining mavs when expecting

@peterbarker peterbarker deleted the pr/networking-tests-diagnostics branch March 13, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants