Attempt at fixing sub flapping test #26426
Conversation
| @@ -4460,7 +4460,7 @@ def TestLogDownloadMAVProxyNetwork(self, upload_logs=False): | |||
| self.mavproxy_load_module(mavproxy, 'log') | |||
| self.wait_heartbeat() | |||
| mavproxy.send("log list\n") | |||
| mavproxy.expect("numLogs") | |||
| mavproxy.expect("numLogs", timeout=120) | |||
There was a problem hiding this comment.
This is probably not going to work.
UDPMulticast and UDPBroadcast are lossy. Neither MAVProxy nor the autotest suite have retry logic to account for that.
I added a few notes over here (which should probably be on Buzz's issue): #26371
There was a problem hiding this comment.
Oh i see. fair enough. I'll close this then. Why does it look like it is only happening with Sub, though?
There was a problem hiding this comment.
oh, I just remembered why I made this:
https://github.com/ArduPilot/ardupilot/actions/runs/8178212379/job/22362301977#step:7:19363
it does look like a log list comes through after the timeout.
There was a problem hiding this comment.
I guess there's an extra message from mavproxy saying the total number of logs? that would make sense.
There was a problem hiding this comment.
Oh i see. fair enough. I'll close this then. Why does it look like it is only happening with Sub, though?
The sub test suite is where the new tests for log-download-over multicast were put....
No description provided.