Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing sub flapping test #26426

Closed
wants to merge 1 commit into from
Closed

Attempt at fixing sub flapping test #26426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tools/autotest/vehicle_test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4460,7 +4460,7 @@ def TestLogDownloadMAVProxyNetwork(self, upload_logs=False):
self.mavproxy_load_module(mavproxy, 'log')
self.wait_heartbeat()
mavproxy.send("log list\n")
mavproxy.expect("numLogs")
mavproxy.expect("numLogs", timeout=120)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not going to work.

UDPMulticast and UDPBroadcast are lossy. Neither MAVProxy nor the autotest suite have retry logic to account for that.

I added a few notes over here (which should probably be on Buzz's issue): #26371

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i see. fair enough. I'll close this then. Why does it look like it is only happening with Sub, though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I just remembered why I made this:
https://github.com/ArduPilot/ardupilot/actions/runs/8178212379/job/22362301977#step:7:19363

it does look like a log list comes through after the timeout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's an extra message from mavproxy saying the total number of logs? that would make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i see. fair enough. I'll close this then. Why does it look like it is only happening with Sub, though?

The sub test suite is where the new tests for log-download-over multicast were put....

# ensure the full list of logs has come out
for i in range(5):
self.wait_heartbeat()
Expand Down
Loading