autotest: ensure latest log is timestamped, small and not growing #26486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Mar 12, 2024
A fixed time this log is open for ensures we know what we are downloading. We will not be keeping dataflash logs of the rest of this test after this PR as we leave LOG_DISARMED as it is. Waiting for GPS ensures the file gets a timestamp, so MAVProxy's "log download latest" will return that log file.
peterbarker
force-pushed
the
pr/fix-download-test
branch
from
11157e4 to
636383d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fixed time this log is open for ensures we know what we are downloading.
We will not be keeping dataflash logs of the rest of this test after this PR as we leave LOG_DISARMED as it is.
Waiting for GPS ensures the file gets a timestamp, so MAVProxy's "log download latest" will return that log file.
This is an excerpt from a test which failed in CI. Note that the log being downloaded is massive, despite the test's attempts to make a small log (it is not downloading the latest log, but the previous). This is because that really small log does not have a timestamp associated with it before the simulation gets GPS, and MAVProxy's
log download latesttreats zero as oldest-log. Key line is "Downloading log 23 as..."