Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_ExternalAHRS: Remove incorrect 0xFFFF default comment #26600

Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Mar 23, 2024

The GPS week value of 0xFFFF is a hold-over from MSP. None of the EAHRS systems set that value now, and it's not handled in any special way in AP_GPS.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the microstrain should not be passing partial data to AP_GPS, see InertialLabs driver for example

* It's a hold-over from MSP. None of AP handles 0xFFFF in a special way

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55 Ryanf55 force-pushed the eahrs-default-gps-week-unknown branch from fa18b2e to 812fd19 Compare March 26, 2024 02:21
@Ryanf55 Ryanf55 marked this pull request as ready for review March 26, 2024 02:22
@Ryanf55 Ryanf55 changed the title AP_ExternalAHRS: Default to no GPS week data AP_ExternalAHRS: Remove incorrect 0xFFFF default comment Mar 26, 2024
@Ryanf55 Ryanf55 marked this pull request as draft May 12, 2024 06:04
@Ryanf55 Ryanf55 marked this pull request as ready for review September 13, 2024 16:34
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Sep 13, 2024

@peterbarker Please review/merge

@peterbarker peterbarker merged commit 2aa5db5 into ArduPilot:master Sep 13, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants