AP_InertialSensor: Improve bitmask indicating persistent parameters on bootloader flash #26623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshanne
commented
Mar 25, 2024
| // @Description: This enables optional temperature calibration features. Setting PersistParams will save the accelerometer and temperature calibration parameters in the bootloader sector on the next update of the bootloader. | ||
| // @Bitmask: 0:PersistParams | ||
| // @Description: This enables optional temperature calibration features. Setting of the Persist bits will save the temperature and/or accelerometer calibration parameters in the bootloader sector on the next update of the bootloader. | ||
| // @Bitmask: 0:PersistTemps 1:PersistAccels |
…n bootloader flash INS_TCAL_OPTIONS parameter description indicates a singular bit in a bitmask to persist Accels/TCAL parameters, however there are two separate bits for persistence.
joshanne
force-pushed
the
improve-tcal-options-parameter-bitmask-description
branch
from
783cbc8 to
a4d43d7
Compare
joshanne
added a commit
to joshanne/ardupilot_wiki
that referenced
this pull request
Mar 25, 2024
…ently saving Relates to: ArduPilot/ardupilot#26623
tridge
approved these changes
Mar 26, 2024
tridge
pushed a commit
to ArduPilot/ardupilot_wiki
that referenced
this pull request
Mar 30, 2024
…ently saving Relates to: ArduPilot/ardupilot#26623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current param description indicates that bit 0 will do both accels and tempcals. However,
INS_TCAL_OPTIONSis a bitmask that is used to persist 0:tempcals and 1:accels (or both).See: TCalOptions Definition
I don't have access to add labels to wiki, but there is an associated wiki PR to better describe how to use the persistence here: ardupilot_wiki PR#5841