Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for NxtPX4v2 #26639

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Support for NxtPX4v2 #26639

merged 2 commits into from
Apr 24, 2024

Conversation

Minderring
Copy link
Contributor

The NxtPX4v2 is an open-source hardware designed and maintened by HKUST UAV-Group. And it is produced by MicoAir Tech..

Waiting for your reply!
Best Regard!

@peterbarker peterbarker requested a review from Hwurzburg April 10, 2024 04:55
@Minderring Minderring mentioned this pull request Apr 10, 2024
Merged
andyp1per
andyp1per approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you need to update the board id and maybe set the ESC telemetry protocol

libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/defaults.parm Show resolved Hide resolved
@peterbarker
Copy link
Contributor

@Minderring needs a rebase

@Minderring Minderring force-pushed the hwdef_add_NxtPX4v2 branch 4 times, most recently from 5b09c29 to 4430aa0 Compare April 11, 2024 09:59
@Minderring
Copy link
Contributor Author

The board ID has been merged and rebased. @peterbarker @andyp1per @Hwurzburg
If there is anything that needs to be modified, please let me know.

@peterbarker
Copy link
Contributor

The board ID has been merged and rebased. @peterbarker @andyp1per @Hwurzburg If there is anything that needs to be modified, please let me know.

I've marked it as MergeOnCIPass

@Hwurzburg
Copy link
Collaborator

I need to review..will do so ASAP

Hwurzburg
Hwurzburg requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few tweaks and one major HWDEF issue that will prevent it being built
also the back view image needs to have TX4/RX4 labels instead of just TX/RX on the SERIAL2 connector

libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/README.md Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/README.md Outdated Show resolved Hide resolved
@Minderring Minderring mentioned this pull request Apr 12, 2024
Merged
@Minderring Minderring force-pushed the hwdef_add_NxtPX4v2 branch 2 times, most recently from 6b7791a to ba5a2d0 Compare April 12, 2024 07:40
@Minderring
Copy link
Contributor Author

a few tweaks and one major HWDEF issue that will prevent it being built also the back view image needs to have TX4/RX4 labels instead of just TX/RX on the SERIAL2 connector

Thank you for your suggestion! I have fixed them all. Please take a look. @Hwurzburg

@Minderring Minderring requested a review from Hwurzburg April 12, 2024 08:31
Hwurzburg
Hwurzburg approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minderring Minderring requested a review from peterbarker April 12, 2024 12:44
@Minderring Minderring force-pushed the hwdef_add_NxtPX4v2 branch 2 times, most recently from 5c700de to 4b270c8 Compare April 18, 2024 07:09
@Minderring
Copy link
Contributor Author

@peterbarker Hi! I have rebased and please take a look.

@Minderring
AP_HAL_ChibiOS: added NxtPX4v2
f6e3fb7 
Update README.md

Update NxtPX4v2_BackView

Hwdef Remove: define HAL_GPIO_LED_OFF 0
@Hwurzburg
Copy link
Collaborator

@Minderring again, please describe the changes in the the force pushes since reviews were done...otherwise we will have to wait until we can find time to do a complete re-review

@Minderring
Copy link
Contributor Author

Minderring commented Apr 23, 2024 •
edited
Loading

@Minderring again, please describe the changes in the the force pushes since reviews were done...otherwise we will have to wait until we can find time to do a complete re-review

@Hwurzburg Sorry! Just a minor change since the last approved review.
I corrected some errors in the NxtPX4v2_BackView.jpg regarding the AUX label, then I rebased it, and that was all. Nothing else.

@Hwurzburg
Copy link
Collaborator

lets us know when testing is completed and will mark for DevCall and merge

@Minderring
Copy link
Contributor Author

lets us know when testing is completed and will mark for DevCall and merge

@Hwurzburg Thanks! It was thoroughly tested last month and continues to perform well.

@tridge tridge merged commit 8490047 into ArduPilot:master Apr 24, 2024
44 checks passed
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg approved these changes

@andyp1per andyp1per andyp1per approved these changes

@tridge tridge tridge approved these changes

@peterbarker peterbarker Awaiting requested review from peterbarker

Assignees
No one assigned
Labels
WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Minderring @peterbarker @Hwurzburg @tridge @andyp1per @IamPete1