-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Mount: add topotek gimbal driver #27053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs MNT_TYPE metadata addition
We discussed this on the dev call and the major concern was that the driver consumes far too much flash (about 9K). Various devs have given suggestions on how it could be made smaller so I will attempt to rework the driver based on this advice. |
Okay, I will start working on the modifications, thank you. |
This came up on the dev call and Tridge and I agreed that we should help make this driver smaller. I've got a 2 week vacation coming up soon but hopefully we can help. |
Thank you for your help. I will try my best to complete it this week. Thank you. |
Sorry, I've been very busy recently. I will finish it as soon as possible |
Just FYI, I've started shrinking the driver and I expect I will complete it within the next week. No need to stress, I just wanted to make sure we don't waste effort by both doing the same thing. |
Thank you for your advice. I will revise it right away. I feel very sorry for having to deal with a lot of urgent things recently |
Co-authored-by: Randy Mackay <[email protected]>
Co-authored-by: Randy Mackay <[email protected]>
Tridge's requests completed
This adds support for the Topotek gimbals and replaces #26666
This has been heavily reworked to reduced its flash size (now 6660 on CubeOrangePlus) and to make it more robust to errors.
This has been tested on real hardware including confirming that:
Some of the changes compared to the initial PR are:
The only known issues are:
@laozhou-fujian this builds on your PR and the single commit is now Co-authored by both of us. Can you confirm you are OK with these changes?
Size comparison
Wiki PR ArduPilot/ardupilot_wiki#6092