-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: ros2: Improve ability to launch plane in headless mode #27131
Tools: ros2: Improve ability to launch plane in headless mode #27131
Conversation
* Install models for other users * Fix bool parsing in some launch args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only question is whether we need the additional JSON files from the directory containing the plane.parm
file.
The DDS refs file is already installed to |
I wasn't sure. If you think I should leave them out, I'll add a matcher to only copy |
No,let me try using that in the launch file. Without specifying the refs, it fails to boot.
Once I add this, it works; <include file="$(find-pkg-share ardupilot_sitl)/launch/sitl_dds_udp.launch.py">
<arg name="defaults" value="$(find-pkg-share ardupilot_sitl)/config/models/plane.parm"/>
<arg name="model" value="plane"/>
<arg name="command" value="arduplane"/>
<arg name="refs" value="$(find-pkg-share ardupilot_sitl)/config/dds_xrce_profile.xml"/>
</include> Nothing needs to change in this PR, so I think the code is good to go as-is. |
It's good as is.
LGTM. The launch examples at the end of the |
@srmainwaring Thoughts on backporting this to 4.5? |
Purpose
plane.parm
that SITL launches with for planeTesting
Create a launch file with the contents;
ros2 launch your_package your_launch_file.launch.xml \ refs:=$(pwd)/src/ardupilot/libraries/AP_DDS/dds_xrce_profile.xml \ map:=True \ console:=True
Then, change map and console to false and observe them not appear.
The plane should boot up just like sim_vehicle, and be able to use mavproxy.
Mavproxy should show a plane icon.
Issue
Solves #27130
I found this running
colcon test
and saw a ton of windows popping up.Follow up
I'd like CMake to install the refs file and default that location so you don't need to specify the refs path when you launch in a directory other than ardupilot.