Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS Backports to 4.5 #27919

Merged
merged 9 commits into from
Sep 25, 2024
Merged

DDS Backports to 4.5 #27919

merged 9 commits into from
Sep 25, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Aug 24, 2024

Backport the following DDS features/fixes that are low-risk and ABI compatible:

They were ported in the following order. A few merge conflicts to resolve were caused by the ABI breaking change to remove the refs file, and the experimental IMU topic that we do not want on 4.5.

Many of these were all requested by a commercial user of Ardupilot DDS and have been thoroughly tested on master for a while.

Tiziano Fiorenzani and others added 3 commits August 21, 2024 20:29
* These can be set in ros2 launch calls now

Signed-off-by: Ryan Friedman <[email protected]>
* Install models for other users
* Fix bool parsing in some launch args
@Ryanf55 Ryanf55 marked this pull request as draft August 24, 2024 23:03
srmainwaring and others added 5 commits August 25, 2024 20:25
- Require reboot.
- Set DDS_DOMAIN_ID range: 0 to 232..

Signed-off-by: Rhys Mainwaring <[email protected]>
- ROS expects quaternions to be normalised and the default message constructor does not enforce this.
- Fix normalisation for pose stamped.

Signed-off-by: Rhys Mainwaring <[email protected]>
* Depend on all messages used in ardupilot_sitl
* Clarify limitations of wrapping with colcon
* Link github issue to support argument passthrough

Signed-off-by: Ryan Friedman <[email protected]>
the std:copy was copying from uint16_t to float
@Ryanf55 Ryanf55 marked this pull request as ready for review August 26, 2024 04:49
@Ryanf55 Ryanf55 requested a review from rmackay9 August 26, 2024 04:49
@tridge
Copy link
Contributor

tridge commented Aug 26, 2024

held off for 4.5.7

@rmackay9
Copy link
Contributor

We decided we will merge this after 4.5.6 goes out as the stable so this should be included in 4.5.7-beta1

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Sep 5, 2024

We decided we will merge this after 4.5.6 goes out as the stable so this should be included in 4.5.7-beta1

Now that 4.5.6 is out, is this ok to merge for the next beta?

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Sep 21, 2024

Added #28141

Copy link
Contributor

@srmainwaring srmainwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have thanks @Ryanf55. Builds fine for SITL and CubeOrangePlus. Should have a chance to flight test this week. These should address the issue of reading rosbag TF in rviz2.

Update flight tested today on EDU-450 / CubeOrange+. All good. I'll share the rosbag of the short survey mission if it recorded correctly.

@rmackay9 rmackay9 merged commit 2403651 into ArduPilot:Copter-4.5 Sep 25, 2024
93 checks passed
@rmackay9
Copy link
Contributor

One copter test was failing but I think it was a flapping test so I've merged it. This will be included in 4.5.7-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 4.5.7-beta1
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants