-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDS Backports to 4.5 #27919
DDS Backports to 4.5 #27919
Conversation
* These can be set in ros2 launch calls now Signed-off-by: Ryan Friedman <[email protected]>
* Install models for other users * Fix bool parsing in some launch args
- Require reboot. - Set DDS_DOMAIN_ID range: 0 to 232.. Signed-off-by: Rhys Mainwaring <[email protected]>
- ROS expects quaternions to be normalised and the default message constructor does not enforce this. - Fix normalisation for pose stamped. Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
* Depend on all messages used in ardupilot_sitl * Clarify limitations of wrapping with colcon * Link github issue to support argument passthrough Signed-off-by: Ryan Friedman <[email protected]>
the std:copy was copying from uint16_t to float
30db0f3
to
6f867e2
Compare
held off for 4.5.7 |
We decided we will merge this after 4.5.6 goes out as the stable so this should be included in 4.5.7-beta1 |
Now that 4.5.6 is out, is this ok to merge for the next beta? |
Signed-off-by: Ryan Friedman <[email protected]>
Added #28141 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have thanks @Ryanf55. Builds fine for SITL and CubeOrangePlus. Should have a chance to flight test this week. These should address the issue of reading rosbag TF in rviz2.
Update flight tested today on EDU-450 / CubeOrange+. All good. I'll share the rosbag of the short survey mission if it recorded correctly.
One copter test was failing but I think it was a flapping test so I've merged it. This will be included in 4.5.7-beta1 |
Backport the following DDS features/fixes that are low-risk and ABI compatible:
They were ported in the following order. A few merge conflicts to resolve were caused by the ABI breaking change to remove the refs file, and the experimental IMU topic that we do not want on 4.5.
Many of these were all requested by a commercial user of Ardupilot DDS and have been thoroughly tested on
master
for a while.