AP_BatteryMonitor: add missing failsafe with no action #27358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
reviewed
Jun 25, 2024
peterbarker
approved these changes
Jun 25, 2024
tridge
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if your battery monitor goes away the only way to tell is a bit in sys status. This is quite easy to miss. This now results in a full battery failsafe with no action. We might want to consider adding a parameter in the future. This uses a 5 second timeout.
This becomes more likely with CAN battery monitors which are often powered from the battery itself, so if the battery fails the node also disappears rather than telling us that the battery is gone.
Example:
