Rover: fix ModeReason on fence breaches #27431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
fence_mode
branch
from
fa38376 to
90021d3
Compare
|
Merged, thanks! Perhaps as @khancyr says we could do even better by mapping the failsafe_trigger method's failsafe_type argument to a ModeReason::FAILSAFE_RADIO or ModeReason::FAILSAFE_GCS but this PR is still an improvement so I've merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if there's an underlying reason for these to be set to BATTERY_FAILSAFE of it it was a mistake.
If it was on purpose, we should at least add a comment explaining what is going on.