AP_ExternalAHRS: Fix Build Option for InertialLabs #27819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build_options cannot autodetect InertialLabs since the feature is extracted as AP_EXTERNAL_AHRS_INERTIALLABS_ENABLED (without the underscore). This allows you to define in/out InertialLabs properly.
|
@peterbarker following up from last weeks discussions. |
joshanne
force-pushed
the
pr/fix-extahrs-build-option-inertiallabs
branch
from
b7a9398 to
abe68d6
Compare
joshanne
changed the title
|
Looks like FenceFloorEnabledLanding is flapping. |
peterbarker
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
LGTM.
Note that I have #27777 on the way which, while a bit of a monster, will catch more of these issues in CI.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened after fixing some other build_options/extract_features in #27796
Extraction of the feature generates
INERTIALLABSbut the define usesINERTIAL_LABS.This fixes it so the feature matches the build option.