Tools: autotest: Use GLOBAL keyword to match WGS-84 MSL alt frames #28489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes the missing MAV_FRAME_GLOBAL from the conversion to relative alt Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
changed the title
|
Upstream PR that adds this frame: mavlink/mavlink#2092 |
peterbarker
requested changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes the missing
MAV_FRAME_GLOBALfrom the conversion from absolute to relative alt.I observed when using this conversion on some new plane tests, repeat tests result in long climbs that slow the test down and even fail it without longer timeouts.
Using the "in" keyword for substring containment
Docs
https://mavlink.io/en/messages/common.html#MAV_FRAME
Tests Performed
Copter autotest
This causes test failures:
https://github.com/ArduPilot/ardupilot/actions/runs/11565307247/job/32192397166?pr=28489#step:11:15192
This seems like very odd behavior. Perhaps it could use some docs on why
MAV_FRAME_GLOBALmust be treated different?